ArnavBalyan commented on code in PR #3296:
URL: https://github.com/apache/parquet-java/pull/3296#discussion_r2324131704
##########
parquet-cli/src/test/java/org/apache/parquet/cli/commands/FileTest.java:
##########
@@ -33,13 +33,13 @@
public abstract class FileTest {
- static final String INT32_FIELD = "int32_field";
- static final String INT64_FIELD = "int64_field";
- static final String FLOAT_FIELD = "float_field";
- static final String DOUBLE_FIELD = "double_field";
- static final String BINARY_FIELD = "binary_field";
- static final String FIXED_LEN_BYTE_ARRAY_FIELD = "flba_field";
- static final String DATE_FIELD = "date_field";
+ public static final String INT32_FIELD = "int32_field";
+ public static final String INT64_FIELD = "int64_field";
+ public static final String FLOAT_FIELD = "float_field";
+ public static final String DOUBLE_FIELD = "double_field";
+ public static final String BINARY_FIELD = "binary_field";
+ public static final String FIXED_LEN_BYTE_ARRAY_FIELD = "flba_field";
+ public static final String DATE_FIELD = "date_field";
Review Comment:
updated
##########
parquet-cli/src/main/java/org/apache/parquet/cli/Main.java:
##########
@@ -82,7 +82,8 @@ public class Main extends Configured implements Tool {
@VisibleForTesting
final JCommander jc;
- Main(Logger console) {
+ @VisibleForTesting
+ public Main(Logger console) {
Review Comment:
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
