wgtmac commented on code in PR #3448:
URL: https://github.com/apache/parquet-java/pull/3448#discussion_r2944371322
##########
parquet-column/src/test/java/org/apache/parquet/column/statistics/TestStatistics.java:
##########
@@ -927,4 +927,16 @@ public void testNoopStatistics() {
assertThrows(UnsupportedOperationException.class, stats::minAsString);
assertThrows(UnsupportedOperationException.class, () ->
stats.isSmallerThan(0));
}
+
+ @Test
+ public void testBinaryIsSmallerThanNoOverflowForLargeValues() {
+ PrimitiveType type = Types.required(BINARY).named("test_binary");
+ Statistics<?> stats = Statistics.getBuilderForReading(type).build();
+
+ byte[] largeValue = new byte[1_073_741_824]; // 2^30 = 1 GB
Review Comment:
Do we really need to allocate such large memory in the test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
