alamb commented on code in PR #562:
URL: https://github.com/apache/parquet-format/pull/562#discussion_r3028286996
##########
LogicalTypes.md:
##########
@@ -571,7 +571,8 @@ type `binary`, which is also called `BYTE_ARRAY` in the
Parquet thrift definitio
The `VARIANT` annotated group can be used to store either an unshredded Variant
value, or a shredded Variant value.
-* The Variant group must be annotated with the `VARIANT` logical type.
+* The Variant group must be annotated with the `VARIANT` logical type, with
the version number
+ "1" included in the declaration.
Review Comment:
```suggestion
* The Variant group must be annotated with the `VARIANT` logical type, with
the version number
included in the declaration.
```
since "1" may change, this might be more future proof:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
