steveloughran commented on code in PR #3472:
URL: https://github.com/apache/parquet-java/pull/3472#discussion_r3088714791
##########
parquet-variant/src/test/java/org/apache/parquet/variant/TestVariantScalarBuilder.java:
##########
@@ -387,6 +387,17 @@ public void testBinaryBuilder() {
}
}
+ @Test
+ public void testBinaryBuilderDoesNotMutateCallerBuffer() {
+ ByteBuffer buf = ByteBuffer.wrap(new byte[] {0, 1, 2, 3});
+ int positionBefore = buf.position();
+ int remainingBefore = buf.remaining();
+ VariantBuilder vb = new VariantBuilder();
+ vb.appendBinary(buf);
+ Assert.assertEquals(positionBefore, buf.position());
Review Comment:
nit add a "position" and "remaining" description for better diagnostics on
CI runs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
