Fokko commented on code in PR #3467:
URL: https://github.com/apache/parquet-java/pull/3467#discussion_r3156613757
##########
parquet-column/src/main/java/org/apache/parquet/column/values/rle/RunLengthBitPackingHybridDecoder.java:
##########
@@ -90,17 +92,23 @@ private void readNext() throws IOException {
case PACKED:
int numGroups = header >>> 1;
currentCount = numGroups * 8;
+ currentBufferLength = currentCount;
LOG.debug("reading {} values BIT PACKED", currentCount);
- currentBuffer = new int[currentCount]; // TODO: reuse a buffer
- byte[] bytes = new byte[numGroups * bitWidth];
- // At the end of the file RLE data though, there might not be that
many bytes left.
- int bytesToRead = (int) Math.ceil(currentCount * bitWidth / 8.0);
- bytesToRead = Math.min(bytesToRead, in.available());
- new DataInputStream(in).readFully(bytes, 0, bytesToRead);
+ if (currentBuffer == null || currentBuffer.length < currentCount) {
+ currentBuffer = new int[currentCount];
+ }
Review Comment:
```suggestion
} else {
Arrays.fill(currentBuffer, currentCount, currentBuffer.length,
0);
}
```
##########
parquet-column/src/main/java/org/apache/parquet/column/values/rle/RunLengthBitPackingHybridDecoder.java:
##########
@@ -90,17 +92,23 @@ private void readNext() throws IOException {
case PACKED:
int numGroups = header >>> 1;
currentCount = numGroups * 8;
+ currentBufferLength = currentCount;
LOG.debug("reading {} values BIT PACKED", currentCount);
- currentBuffer = new int[currentCount]; // TODO: reuse a buffer
- byte[] bytes = new byte[numGroups * bitWidth];
- // At the end of the file RLE data though, there might not be that
many bytes left.
- int bytesToRead = (int) Math.ceil(currentCount * bitWidth / 8.0);
- bytesToRead = Math.min(bytesToRead, in.available());
- new DataInputStream(in).readFully(bytes, 0, bytesToRead);
+ if (currentBuffer == null || currentBuffer.length < currentCount) {
+ currentBuffer = new int[currentCount];
+ }
+ int bytesNeeded = numGroups * bitWidth;
+ if (packedBytes == null || packedBytes.length < bytesNeeded) {
+ packedBytes = new byte[bytesNeeded];
+ }
Review Comment:
```suggestion
} else {
Arrays.fill(packedBytes, bytesNeeded, packedBytes.length, (byte)
0);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
