Fokko commented on code in PR #3533:
URL: https://github.com/apache/parquet-java/pull/3533#discussion_r3197532011
##########
parquet-column/src/main/java/org/apache/parquet/column/values/dictionary/IntList.java:
##########
@@ -150,11 +152,6 @@ public IntIterator iterator() {
* @return the current size of the list
*/
public int size() {
- int size = currentSlabPos;
- for (int[] slab : slabs) {
- size += slab.length;
- }
Review Comment:
I don't think this change is correct. We're returning the slab length, and
this one can grow as well (double until MAX_SLAB_SIZE)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
