arouel commented on code in PR #3488:
URL: https://github.com/apache/parquet-java/pull/3488#discussion_r3422246149
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java:
##########
@@ -1150,6 +1150,7 @@ public PageReadStore readNextRowGroup() throws
IOException {
if (rowGroup == null) {
return null;
}
+ closeCurrentRowGroup();
Review Comment:
Good catch, this ensures the last row group's buffers are freed as soon as
iteration is exhausted, not deferred to `close()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]