alkis commented on code in PR #585:
URL: https://github.com/apache/parquet-format/pull/585#discussion_r3430299756


##########
src/main/thrift/parquet.thrift:
##########
@@ -468,6 +468,21 @@ struct GeographyType {
   2: optional EdgeInterpolationAlgorithm algorithm;
 }
 
+/**
+ * File logical type annotation
+ *
+ * Annotates a group that represents a reference to an external file.
+ * The group must contain the following fields identified by name:
+ *   - path (STRING, required): an opaque string path to the file (e.g. 
s3://bucket/file.jpg)

Review Comment:
   Can we make this optional and say if it is NULL or empty the path is the 
parquet file itself? This makes a parquet file self contained and moveable 
trivially (renaming the file itself does not require a re-encoding pass).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to