pitrou commented on code in PR #585:
URL: https://github.com/apache/parquet-format/pull/585#discussion_r3556813316
##########
src/main/thrift/parquet.thrift:
##########
@@ -468,6 +468,21 @@ struct GeographyType {
2: optional EdgeInterpolationAlgorithm algorithm;
}
+/**
+ * File logical type annotation
+ *
+ * Annotates a group that represents a reference to an external file.
+ * The group must contain the following fields identified by name:
+ * - path (STRING, required): an opaque string path to the file (e.g.
s3://bucket/file.jpg)
Review Comment:
> I think it's reasonable to clarify that we expect the location to be a
URI, but are you saying that implementations must parse and validate the
contents of the column?
We are talking about the spec, not what implementations do. The STRING type
is specified as UTF8. Putting non-UTF8 data in a STRING column would be invalid
Parquet. Readers will probably not UTF8-validate the contents, they assume the
writer is well-behaved.
This is the same here: we can specify this to be a URI and let readers
decide if they want to be strict about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
