sdf-jkl opened a new pull request, #117: URL: https://github.com/apache/parquet-testing/pull/117
Fixes #116 ### Rationale These four cases omit the required `value` column from a variant group but are labeled as valid cases with expected outputs. Per the discussion in apache/parquet-format#591, the spec's requirement that the group contain a `value` field is intentional and will not be relaxed, so these files are not spec-compliant. The mislabeling has already propagated into implementations that run this corpus in CI (see apache/arrow-rs#10306). | case | test | omission | |---|---|---| | 41 | `testArrayMissingValueColumn` | top-level `value` (typed_value is a LIST) | | 131 | `testMissingValueColumn` | top-level `value` (typed_value is INT32) | | 132 | `testShreddedObjectMissingFieldValueColumn` | `value` inside the shredded object field groups | | 138 | `testShreddedObjectMissingValueColumn` | top-level `value` (typed_value is an object) | ### Changes Follows the existing convention used by cases 43, 84 and 125: - rename `case-NNN.parquet` / `case-NNN_row-0.variant.bin` to `case-NNN-INVALID.parquet` / `case-NNN-INVALID_row-0.variant.bin` - add a `notes` entry in `cases.json` stating the file is not valid according to the spec (with the reason) and that implementations can choose to error, or read the shredded value - keep the expected variant outputs for implementations that choose to read them No file contents were changed, only renames and `cases.json` metadata. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
