emkornfield commented on code in PR #598: URL: https://github.com/apache/parquet-format/pull/598#discussion_r3568492093
########## CONTRIBUTING.md: ########## @@ -138,65 +147,42 @@ For the purposes of this discussion we classify features into the following buck New features are intended to be widely beneficial to users of Parquet, and therefore it is hoped third-party implementations will adopt them quickly after -they are introduced. It is assumed that writing new parts of the format, and -especially forward incompatible features, will be configured with a feature flag -defaulted to "off", and at some future point the feature is turned on by default -(reading of the new feature will typically be enabled without configuration or -defaulted to on). Some amount of lead time is desirable to ensure a critical -mass of Parquet implementations support a feature to avoid compatibility issues +they are introduced. It is expected that implementations will provide a configuration +mechanism for users to enable features when writing parquet file. It is recommended that implementations provide +at least a way to enable all relevant features given a specification version +(e.g. major and minor version). In addition, implementations might choose to +enable features at a finer-grained level with feature flags. + +Some amount of lead time is desirable to ensure a critical +mass of Parquet implementations support a given specification version across the ecosystem. Therefore, the Parquet PMC gives the following -recommendations for managing features: +recommendations for managing the default specification version used for writing: Review Comment: ```suggestion recommendations for managing features: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
