nastra commented on code in PR #3664:
URL: https://github.com/apache/parquet-java/pull/3664#discussion_r3578381284
##########
parquet-arrow/src/test/java/org/apache/parquet/arrow/schema/TestSchemaConverter.java:
##########
@@ -363,54 +363,35 @@ private static Field field(String name, ArrowType type,
Field... children) {
@Test
public void testComplexArrowToParquet() {
MessageType parquet =
converter.fromArrow(complexArrowSchema).getParquetSchema();
- Assert.assertEquals(complexParquetSchema.toString(), parquet.toString());
// easier to read
- Assert.assertEquals(complexParquetSchema, parquet);
+ assertThat(parquet).asString().isEqualTo(complexParquetSchema.toString());
// easier to read
+ assertThat(parquet).isEqualTo(complexParquetSchema);
}
@Test
public void testAllArrowToParquet() {
MessageType parquet =
converter.fromArrow(allTypesArrowSchema).getParquetSchema();
- Assert.assertEquals(allTypesParquetSchema.toString(), parquet.toString());
// easier to read
- Assert.assertEquals(allTypesParquetSchema, parquet);
+
assertThat(parquet).asString().isEqualTo(allTypesParquetSchema.toString()); //
easier to read
+ assertThat(parquet).isEqualTo(allTypesParquetSchema);
}
@Test
public void testSupportedParquetToArrow() {
Schema arrow =
converter.fromParquet(supportedTypesParquetSchema).getArrowSchema();
- assertEquals(supportedTypesArrowSchema, arrow);
+ assertThat(arrow).isEqualTo(supportedTypesArrowSchema);
}
@Test
public void testRepeatedParquetToArrow() {
Schema arrow = converter.fromParquet(Paper.schema).getArrowSchema();
- assertEquals(paperArrowSchema, arrow);
- }
-
- public void assertEquals(Schema left, Schema right) {
Review Comment:
not used anywhere anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
