rdblue commented on code in PR #3610:
URL: https://github.com/apache/parquet-java/pull/3610#discussion_r3582671339
##########
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java:
##########
@@ -911,8 +916,16 @@ private static byte[] tuncateMax(BinaryTruncator
truncator, int truncateLength,
}
private static boolean isMinMaxStatsSupported(PrimitiveType type) {
- return type.columnOrder().getColumnOrderName() ==
ColumnOrderName.TYPE_DEFINED_ORDER
- || type.columnOrder().getColumnOrderName() ==
ColumnOrderName.IEEE_754_TOTAL_ORDER;
+ switch (type.columnOrder().getColumnOrderName()) {
+ case TYPE_DEFINED_ORDER:
+ case IEEE_754_TOTAL_ORDER:
+ case INT96_TIMESTAMP_ORDER:
+ return true;
+ case UNDEFINED:
+ return false;
+ default:
+ throw new IllegalArgumentException("Unknown column order: " +
type.columnOrder());
Review Comment:
Nit: I think we would normal throw `UnsupportedOperationException` since
this is a valid argument (it's an enum after all).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
