nastra commented on code in PR #3676:
URL: https://github.com/apache/parquet-java/pull/3676#discussion_r3621111079
##########
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestAdaptiveBlockSplitBloomFiltering.java:
##########
@@ -22,43 +22,57 @@
import static org.assertj.core.api.Assertions.assertThat;
import java.io.IOException;
+import java.util.stream.Stream;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.Path;
import org.apache.parquet.ParquetReadOptions;
import org.apache.parquet.crypto.FileDecryptionProperties;
import org.apache.parquet.hadoop.util.HadoopInputFile;
import org.apache.parquet.io.InputFile;
-import org.junit.BeforeClass;
-import org.junit.Test;
+import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
-public class TestAdaptiveBlockSplitBloomFiltering extends TestBloomFiltering {
+public class TestAdaptiveBlockSplitBloomFiltering {
Review Comment:
refactoring this test is unfortunately more involved, so I opted for just
using the `TestBloomFiltering` as an instance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
