kevinjqliu opened a new issue, #3682:
URL: https://github.com/apache/parquet-java/issues/3682
## Description
Building Parquet directly from the 1.18.0 RC1 source tarball leaves
`${buildNumber}` unresolved because the archive contains no Git metadata:
```text
parquet-mr version 1.18.0 (build ${buildNumber})
```
The staged JARs correctly contain commit
`5e2ad0969c7f411613671c5ef054d399995de5f9`.
## Impact
The unresolved value affects:
- `Version.FULL_VERSION` and CLI version output.
- The `created_by` metadata written into Parquet files.
- The JAR manifest, where `git-SHA-1` is empty.
- Consistency between source-built and staged JARs.
## Reproduction
```sh
tar xf apache-parquet-1.18.0.tar.gz
cd apache-parquet-1.18.0
./mvnw -DskipTests package
java -cp parquet-common/target/parquet-common-1.18.0.jar
org.apache.parquet.Version
```
## Expected behavior
Source-tarball builds should never contain an unresolved Maven expression.
Use the supplied release revision when available, with an explicit
deterministic fallback such as `unknown`, and add a test that rejects
`${buildNumber}` in generated artifacts.
## References
- [RC1 source
archive](https://dist.apache.org/repos/dist/dev/parquet/apache-parquet-1.18.0-rc1/)
- [RC1
commit](https://github.com/apache/parquet-java/tree/5e2ad0969c7f411613671c5ef054d399995de5f9)
-
[`parquet-version.properties`](https://github.com/apache/parquet-java/blob/5e2ad0969c7f411613671c5ef054d399995de5f9/parquet-generator/src/main/resources/parquet-version.properties#L20)
-
[`VersionGenerator`](https://github.com/apache/parquet-java/blob/5e2ad0969c7f411613671c5ef054d399995de5f9/parquet-generator/src/main/java/org/apache/parquet/version/VersionGenerator.java#L67-L76)
- [`ParquetFileWriter` uses `Version.FULL_VERSION` for
`created_by`](https://github.com/apache/parquet-java/blob/5e2ad0969c7f411613671c5ef054d399995de5f9/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java#L1878-L1884)
- [CLI version
output](https://github.com/apache/parquet-java/blob/5e2ad0969c7f411613671c5ef054d399995de5f9/parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowVersionCommand.java#L34-L38)
- [Manifest `git-SHA-1`
configuration](https://github.com/apache/parquet-java/blob/5e2ad0969c7f411613671c5ef054d399995de5f9/pom.xml#L386-L392)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
