kevinjqliu opened a new pull request, #3686: URL: https://github.com/apache/parquet-java/pull/3686
<!-- Thanks for opening a pull request! If you're new to Parquet-Java, information on how to contribute can be found here: https://parquet.apache.org/docs/contribution-guidelines/contributing Please open a GitHub issue for this pull request: https://github.com/apache/parquet-java/issues/new/choose and format pull request title as below: GH-${GITHUB_ISSUE_ID}: ${SUMMARY} or simply use the title below if it is a minor issue: MINOR: ${SUMMARY} --> ### Rationale for this change ASF [release policy](https://www.apache.org/legal/release-policy.html#licensing-documentation) requires JARs to include `LICENSE` and `NOTICE` under `META-INF`. Note that this PR only adds the `LICENSE` and `NOTICE` files back to the jars. We still need to follow up and validate the content of those files. #### Background The shared ASF Maven parent (`org.apache:apache:39`) configures `maven-remote-resources-plugin` to generate `LICENSE` and `NOTICE` files and include them in each project’s JAR. For example, `parquet-avro` and `parquet-cli` provide both files directly, while several other modules provide only one or neither. This results in inconsistent licensing metadata across the published JARs. The `skip=true` configuration was introduced in [#284](https://github.com/apache/parquet-java/pull/284) ([commit 57694790](https://github.com/apache/parquet-java/commit/57694790f8ca0e1a4f3ac76fbd25a6dd13041e03)) as part of the Cascading 3 changes. ### What changes are included in this PR? Remove `skip=true` from `maven-remote-resources-plugin` ### Are these changes tested? Yes manually Build all jars and validate each contains both `LICENSE` and `NOTICE`: ``` find . -type d -name target -prune -exec rm -rf -- {} + && \ ./mvnw -T 1 package -DskipTests && \ find . -path '*/target/*.jar' -type f ! -name 'original-*' -print0 | while IFS= read -r -d '' jar_file; do contents=$(jar tf "$jar_file") || exit 1 grep -qx 'META-INF/LICENSE' <<<"$contents" && grep -qx 'META-INF/NOTICE' <<<"$contents" || { echo "Missing LICENSE or NOTICE: $jar_file"; exit 1; } done ``` ### Are there any user-facing changes? <!-- Please uncomment the line below and replace ${GITHUB_ISSUE_ID} with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
