kevinjqliu commented on issue #3690:
URL: https://github.com/apache/parquet-java/issues/3690#issuecomment-5085686385
I checked the final binary JARs on `master`. These are the third-party
dependencies whose classes are physically present:
| JAR | Bundled third-party dependencies |
|---|---|
| `parquet-avro-*.jar` | `it.unimi.dsi:fastutil:8.5.18` |
| `parquet-column-*.jar` |
`it.unimi.dsi:fastutil:8.5.18`<br>`net.openhft:zero-allocation-hashing:0.27ea1`
|
| `parquet-format-structures-*.jar` | `org.apache.thrift:libthrift:0.23.0` |
| `parquet-hadoop-*.jar` | `it.unimi.dsi:fastutil:8.5.18` |
| `parquet-jackson-*.jar` |
`com.fasterxml.jackson.core:jackson-annotations:2.22`<br>`com.fasterxml.jackson.core:jackson-core:2.22.1`<br>`com.fasterxml.jackson.core:jackson-databind:2.22.1`
|
| `parquet-hadoop-bundle-*.jar` |
`it.unimi.dsi:fastutil:8.5.18`<br>`net.openhft:zero-allocation-hashing:0.27ea1`<br>`org.apache.thrift:libthrift:0.23.0`<br>`com.fasterxml.jackson.core:jackson-annotations:2.22`<br>`com.fasterxml.jackson.core:jackson-core:2.22.1`<br>`com.fasterxml.jackson.core:jackson-databind:2.22.1`
|
| `parquet-cli-*-runtime.jar` |
`com.beust:jcommander:1.82`<br>`com.fasterxml.jackson.core:jackson-annotations:2.22`<br>`com.fasterxml.jackson.core:jackson-core:2.22.1`<br>`com.fasterxml.jackson.core:jackson-databind:2.22.1`<br>`com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.22.1`<br>`com.github.luben:zstd-jni:1.5.7-11`<br>`commons-codec:commons-codec:1.11`<br>`commons-pool:commons-pool:1.6`<br>`io.airlift:aircompressor:2.0.3`<br>`it.unimi.dsi:fastutil:8.5.18`<br>`javax.annotation:javax.annotation-api:1.3.2`<br>`net.openhft:zero-allocation-hashing:0.27ea1`<br>`net.sf.opencsv:opencsv:2.3`<br>`org.apache.avro:avro:1.11.5`<br>`org.apache.commons:commons-compress:1.26.2`<br>`org.apache.commons:commons-lang3:3.20.0`<br>`org.apache.commons:commons-text:1.15.0`<br>`org.apache.thrift:libthrift:0.23.0`<br>`org.locationtech.jts:jts-core:1.20.0`<br>`org.slf4j:slf4j-api:1.7.33`<br>`org.tukaani:xz:1.12`<br>`org.xerial.snappy:snappy-java:1.1.10.8`
|
The check removes Parquet’s own classes, matches and removes every expected
dependency, and fails if any expected dependency is missing or unexplained
classes remain. All seven JARs ended with zero unmatched classes.
<details>
<summary>Verification command</summary>
Run from the repository root after building the JARs:
```bash
bash <<'EOF'
set -euo pipefail
export LC_ALL=C
tmp_dir=$(mktemp -d)
trap 'rm -rf "$tmp_dir"' EXIT
catalog="$tmp_dir/dependencies"
failures=0
verified_jars=0
cat >"$catalog" <<'CATALOG'
fastutil;it.unimi.dsi:fastutil:8.5.18;^(META-INF/versions/[0-9]+/)?(shaded/parquet/)?it/unimi/dsi/fastutil/
openhft;net.openhft:zero-allocation-hashing:0.27ea1;^(META-INF/versions/[0-9]+/)?(shaded/parquet/)?net/openhft/hashing/
thrift;org.apache.thrift:libthrift:0.23.0;^(META-INF/versions/[0-9]+/)?shaded/parquet/org/apache/thrift/
jackson-annotations;com.fasterxml.jackson.core:jackson-annotations:2.22;^(META-INF/versions/[0-9]+/)?(shaded/parquet/)?com/fasterxml/jackson/annotation/
jackson-core;com.fasterxml.jackson.core:jackson-core:2.22.1;^(META-INF/versions/[0-9]+/)?(shaded/parquet/)?com/fasterxml/jackson/core/|^META-INF/versions/9/module-info\.class$
jackson-databind;com.fasterxml.jackson.core:jackson-databind:2.22.1;^(META-INF/versions/[0-9]+/)?(shaded/parquet/)?com/fasterxml/jackson/databind/
jackson-jsr310;com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.22.1;^(META-INF/versions/[0-9]+/)?com/fasterxml/jackson/datatype/jsr310/
javax-annotation;javax.annotation:javax.annotation-api:1.3.2;^(META-INF/versions/[0-9]+/)?javax/annotation/
jts;org.locationtech.jts:jts-core:1.20.0;^(META-INF/versions/[0-9]+/)?org/locationtech/jts/
snappy;org.xerial.snappy:snappy-java:1.1.10.8;^(META-INF/versions/[0-9]+/)?org/xerial/snappy/
aircompressor;io.airlift:aircompressor:2.0.3;^(META-INF/versions/[0-9]+/)?io/airlift/compress/
commons-pool;commons-pool:commons-pool:1.6;^(META-INF/versions/[0-9]+/)?org/apache/commons/pool/
avro;org.apache.avro:avro:1.11.5;^(META-INF/versions/[0-9]+/)?shaded/parquet/org/apache/avro/
commons-compress;org.apache.commons:commons-compress:1.26.2;^(META-INF/versions/[0-9]+/)?org/apache/commons/compress/
xz;org.tukaani:xz:1.12;^(META-INF/versions/[0-9]+/)?org/tukaani/xz/
zstd;com.github.luben:zstd-jni:1.5.7-11;^(META-INF/versions/[0-9]+/)?com/github/luben/zstd/
slf4j;org.slf4j:slf4j-api:1.7.33;^(META-INF/versions/[0-9]+/)?org/slf4j/
opencsv;net.sf.opencsv:opencsv:2.3;^(META-INF/versions/[0-9]+/)?au/com/bytecode/opencsv/
commons-text;org.apache.commons:commons-text:1.15.0;^(META-INF/versions/[0-9]+/)?org/apache/commons/text/
commons-lang3;org.apache.commons:commons-lang3:3.20.0;^(META-INF/versions/[0-9]+/)?org/apache/commons/lang3/
jcommander;com.beust:jcommander:1.82;^(META-INF/versions/[0-9]+/)?com/beust/(jcommander|ah)/
commons-codec;commons-codec:commons-codec:1.11;^(META-INF/versions/[0-9]+/)?org/apache/commons/codec/
CATALOG
check_jar() {
local jar_file=$1
local jar_name
local expected
local all_classes="$tmp_dir/all-classes"
local remaining="$tmp_dir/remaining"
local next="$tmp_dir/next"
local total_classes
local project_classes
local matched_classes
local remaining_classes
local processed_dependencies=0
local expected_dependencies
jar_name=$(basename "$jar_file")
case "$jar_name" in
parquet-avro-*.jar)
expected="fastutil"
;;
parquet-column-*.jar)
expected="fastutil openhft"
;;
parquet-format-structures-*.jar)
expected="thrift"
;;
parquet-hadoop-bundle-*.jar)
expected="fastutil openhft thrift jackson-annotations jackson-core
jackson-databind"
;;
parquet-hadoop-*.jar)
expected="fastutil"
;;
parquet-jackson-*.jar)
expected="jackson-annotations jackson-core jackson-databind"
;;
parquet-cli-*-runtime.jar)
expected="fastutil openhft thrift jackson-annotations jackson-core
jackson-databind jackson-jsr310 javax-annotation jts snappy
aircompressor commons-pool avro commons-compress xz zstd slf4j
opencsv commons-text commons-lang3 jcommander commons-codec"
;;
*)
return
;;
esac
expected=$(printf '%s' "$expected" | tr '\n' ' ' | tr -s ' ')
verified_jars=$((verified_jars + 1))
if ! jar tf "$jar_file" |
awk '/\.class$/ { print }' >"$all_classes"; then
printf 'FAIL %s: unreadable JAR\n' "$jar_file" >&2
failures=$((failures + 1))
return
fi
total_classes=$(wc -l <"$all_classes" | tr -d ' ')
grep -Ev \
'^(META-INF/versions/[0-9]+/)?org/apache/parquet/' \
"$all_classes" >"$remaining" || true
remaining_classes=$(wc -l <"$remaining" | tr -d ' ')
project_classes=$((total_classes - remaining_classes))
printf '\n%s\n' "$jar_file"
printf ' %-68s %6d classes\n' \
'Parquet project classes' "$project_classes"
while IFS=';' read -r dependency_id coordinate pattern; do
case " $expected " in
*" $dependency_id "*)
;;
*)
continue
;;
esac
processed_dependencies=$((processed_dependencies + 1))
matched_classes=$(grep -Ec "$pattern" "$remaining" || true)
printf ' %-68s %6d classes\n' "$coordinate" "$matched_classes"
if [[ $matched_classes -eq 0 ]]; then
printf ' FAIL: expected dependency matched no classes\n' >&2
failures=$((failures + 1))
continue
fi
grep -Ev "$pattern" "$remaining" >"$next" || true
mv "$next" "$remaining"
done <"$catalog"
expected_dependencies=$(printf '%s\n' "$expected" | wc -w | tr -d ' ')
if [[ $processed_dependencies -ne $expected_dependencies ]]; then
printf ' FAIL: dependency catalog is incomplete\n' >&2
failures=$((failures + 1))
fi
remaining_classes=$(wc -l <"$remaining" | tr -d ' ')
printf ' %-68s %6d classes\n' \
'Unmatched after filtering' "$remaining_classes"
if [[ $remaining_classes -ne 0 ]]; then
printf ' FAIL: unexplained classes remain:\n' >&2
sed 's/^/ /' "$remaining" >&2
failures=$((failures + 1))
fi
}
while IFS= read -r -d '' jar_file; do
check_jar "$jar_file"
done < <(
find parquet-avro parquet-column parquet-format-structures \
parquet-hadoop parquet-jackson parquet-hadoop-bundle parquet-cli \
-type f -path '*/target/*.jar' \
! -name 'original-*.jar' \
! -name '*-tests.jar' \
! -name '*-sources.jar' \
! -name '*-javadoc.jar' \
-print0
)
if [[ $verified_jars -ne 7 ]]; then
printf '\nFAIL: expected 7 JARs, found %d. Run a clean package build
first.\n' \
"$verified_jars" >&2
failures=$((failures + 1))
fi
if [[ $failures -ne 0 ]]; then
printf '\nVerification failed with %d error(s).\n' "$failures" >&2
exit 1
fi
printf '\nVerified %d JARs; every dependency matched and 0 classes
remain.\n' \
"$verified_jars"
EOF
```
</details>
<details>
<summary>Output</summary>
```
parquet-avro/target/parquet-avro-1.18.0-SNAPSHOT.jar
Parquet project classes
106 classes
it.unimi.dsi:fastutil:8.5.18
943 classes
Unmatched after filtering
0 classes
parquet-column/target/parquet-column-1.18.0-SNAPSHOT.jar
Parquet project classes
653 classes
it.unimi.dsi:fastutil:8.5.18
1074 classes
net.openhft:zero-allocation-hashing:0.27ea1
60 classes
Unmatched after filtering
0 classes
parquet-format-structures/target/parquet-format-structures-1.18.0-SNAPSHOT.jar
Parquet project classes
431 classes
org.apache.thrift:libthrift:0.23.0
73 classes
Unmatched after filtering
0 classes
parquet-hadoop/target/parquet-hadoop-1.18.0-SNAPSHOT.jar
Parquet project classes
304 classes
it.unimi.dsi:fastutil:8.5.18
371 classes
Unmatched after filtering
0 classes
parquet-jackson/target/parquet-jackson-1.18.0-SNAPSHOT.jar
Parquet project classes
0 classes
com.fasterxml.jackson.core:jackson-annotations:2.22
77 classes
com.fasterxml.jackson.core:jackson-core:2.22.1
221 classes
com.fasterxml.jackson.core:jackson-databind:2.22.1
812 classes
Unmatched after filtering
0 classes
parquet-hadoop-bundle/target/parquet-hadoop-bundle-1.18.0-SNAPSHOT.jar
Parquet project classes
1795 classes
it.unimi.dsi:fastutil:8.5.18
1074 classes
net.openhft:zero-allocation-hashing:0.27ea1
60 classes
org.apache.thrift:libthrift:0.23.0
73 classes
com.fasterxml.jackson.core:jackson-annotations:2.22
77 classes
com.fasterxml.jackson.core:jackson-core:2.22.1
221 classes
com.fasterxml.jackson.core:jackson-databind:2.22.1
812 classes
Unmatched after filtering
0 classes
parquet-cli/target/parquet-cli-1.18.0-SNAPSHOT-runtime.jar
Parquet project classes
2032 classes
it.unimi.dsi:fastutil:8.5.18
14280 classes
net.openhft:zero-allocation-hashing:0.27ea1
120 classes
org.apache.thrift:libthrift:0.23.0
73 classes
com.fasterxml.jackson.core:jackson-annotations:2.22
154 classes
com.fasterxml.jackson.core:jackson-core:2.22.1
441 classes
com.fasterxml.jackson.core:jackson-databind:2.22.1
1624 classes
com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.22.1
64 classes
javax.annotation:javax.annotation-api:1.3.2
15 classes
org.locationtech.jts:jts-core:1.20.0
732 classes
org.xerial.snappy:snappy-java:1.1.10.8
40 classes
io.airlift:aircompressor:2.0.3
124 classes
commons-pool:commons-pool:1.6
55 classes
org.apache.avro:avro:1.11.5
450 classes
org.apache.commons:commons-compress:1.26.2
571 classes
org.tukaani:xz:1.12
129 classes
com.github.luben:zstd-jni:1.5.7-11
37 classes
org.slf4j:slf4j-api:1.7.33
34 classes
net.sf.opencsv:opencsv:2.3
10 classes
org.apache.commons:commons-text:1.15.0
168 classes
org.apache.commons:commons-lang3:3.20.0
421 classes
com.beust:jcommander:1.82
73 classes
commons-codec:commons-codec:1.11
96 classes
Unmatched after filtering
0 classes
Verified 7 JARs; every dependency matched and 0 classes remain.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
