alkis commented on code in PR #601: URL: https://github.com/apache/parquet-format/pull/601#discussion_r3656070265
########## LogicalTypes.md: ########## @@ -351,11 +351,18 @@ as shown below. ### TIMESTAMP -In data annotated with the `TIMESTAMP` logical type, each value is a single -`int64` number that can be decoded into year, month, day, hour, minute, second -and subsecond fields using calculations detailed below. Please note that a value -defined this way does not necessarily correspond to a single instant on the -time-line and such interpretations are allowed on purpose. +In data annotated with the `TIMESTAMP` logical type, each value is an `int64` +or a 12-byte `FIXED_LEN_BYTE_ARRAY` that can be decoded into year, month, day, +hour, minute, second and subsecond fields using calculations detailed below. +Please note that a value defined this way does not necessarily correspond to a +single instant on the time-line and such interpretations are allowed on purpose. + +For the `int64` carrier, the value is a signed 64-bit integer count of `unit`s +since the Unix epoch. + +For the `FIXED_LEN_BYTE_ARRAY` carrier (with `type_length = 12`), the value is a +signed 96-bit two's-complement little-endian integer count of `unit`s since the Review Comment: I suggest we do big-endian here so that we can use the same signed two complements byte compare we use for DECIMAL in FLBA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
