alamb commented on PR #557: URL: https://github.com/apache/parquet-format/pull/557#issuecomment-5114236056
SInce we have had a successful vote, I suggest we merge this PR and make additional changes as follow on PRs: - https://lists.apache.org/thread/hgmd58wrv9yoopcrf61m1bg211l65tbt From what I can see, it looks like @prtkgaur resolved all blocking comments from @wgtmac 's most recent review (e.g. `parquet.thrift` change). There are a few more style/clarification suggestions from @wgtmac 's I think that we could do as a follow on. Thus, @wgtmac could you confirm you are happy with merging this PR as is (perhaps by approving the PR) and if so I'll merge this PR in and we can continue to iterate in follow on PRs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
