emkornfield commented on code in PR #3680:
URL: https://github.com/apache/parquet-java/pull/3680#discussion_r3672100826
##########
parquet-column/src/test/java/org/apache/parquet/schema/TestPrimitiveStringifier.java:
##########
@@ -417,6 +446,18 @@ private Binary toBinary(int... bytes) {
return Binary.fromConstantByteArray(array);
}
+ // Encodes a unit count as the extended-precision timestamp carrier: a
12-byte signed
+ // two's-complement little-endian value (sign-extended, so negatives fill
the high bytes with
+ // 0xFF).
+ private Binary flba12(long units) {
+ byte[] le = new byte[12];
Review Comment:
nit: might be clearer if we can use BigInteger to byte array and flip the
bytes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
