alamb commented on PR #119: URL: https://github.com/apache/parquet-testing/pull/119#issuecomment-5190422197
> I have fixtures for all three if they'd be helpful, but they'd be more columns on this file rather than separate ones. And I'm happy to contribute the Java-side conformance test to parquet-java once this lands on master. Thanks @vinooganesh > Every data page in the file is V1. Nothing exercises DataPageV2. I think this is ok as I don't think the ALP encoding changes with the datapage format (and thus I don't think we need to cover that dimension in the ALP test cases) > All the NaNs are canonical (0x7FF8000000000000 / 0x7FC00000), so nothing checks that a reader preserves NaN payloads. This is a good point -- I could update the file to also contain some non canonical Nans > The widest FOR bit width in the file is 18. @emkornfield asked us to cover values needing 63/64 bits after FOR on the Java PR, and that case isn't here. This is a good point too -- I think I could update this file so that one of the groups has larger magnitude values that would use a large FOR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
