dossett commented on code in PR #3729:
URL: https://github.com/apache/parquet-java/pull/3729#discussion_r3797528406
##########
parquet-common/src/main/java/org/apache/parquet/bytes/BytesInput.java:
##########
@@ -690,18 +690,9 @@ public ByteBuffer toByteBuffer() throws IOException {
return java.nio.ByteBuffer.wrap(in, offset, length);
}
- /**
- * Zero-copy override: returns the backing array directly when fully used,
- * skipping the base-class BAOS allocation + copy on every decompressor
call.
- * Returning the mutable array is safe — the base class already exposes a
- * mutable {@code BAOS.getBuf()}.
Review Comment:
I think `Returning the mutable array is safe` is the key. The array was
mutable before, but it was a mutable _copy_ of the original array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
