Fokko commented on code in PR #3730: URL: https://github.com/apache/parquet-java/pull/3730#discussion_r3801733105
########## README.md: ########## @@ -43,23 +43,23 @@ Parquet-Java requires Java 17 or higher and uses Maven to build. It also depends To build and install the thrift compiler, run: ``` -wget -nv https://archive.apache.org/dist/thrift/0.23.0/thrift-0.23.0.tar.gz -tar xzf thrift-0.23.0.tar.gz -cd thrift-0.23.0 +wget -nv https://archive.apache.org/dist/thrift/0.24.0/thrift-0.24.0.tar.gz +tar xzf thrift-0.24.0.tar.gz +cd thrift-0.24.0 chmod +x ./configure ./configure --disable-libs sudo make install -j ``` Note: if you wish to verify the signature and checksum of a release: -1. The GPG and sha checksums can be found under https://archive.apache.org/dist/thrift/0.23.0/ +1. The GPG and sha checksums can be found under https://archive.apache.org/dist/thrift/0.24.0/ 2. Validate the signature of the artifact against the [Thrift committer KEYS](https://downloads.apache.org/thrift/KEYS). -If you're on OSX and use homebrew, you can instead install Thrift 0.23.0 with `brew` and ensure that it comes first in your `PATH`. +If you're on OSX and use homebrew, you can instead install Thrift 0.24.0 with `brew` and ensure that it comes first in your `PATH`. ``` brew install thrift -export PATH="/usr/local/opt/[email protected]/bin:$PATH" +export PATH="$(brew --prefix thrift)/bin:$PATH" Review Comment: Unfortunally, this is an improvement since brew does not keep the old Thrift versions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
