peterxcli commented on code in PR #3736:
URL: https://github.com/apache/parquet-java/pull/3736#discussion_r3838838586
##########
parquet-variant/src/main/java/org/apache/parquet/variant/Variant.java:
##########
@@ -273,6 +273,8 @@ public Variant getFieldByKey(String key) {
}
}
Review Comment:
I'm thinking if we could just do binary search anyway. as arrow-rs does it.
https://github.com/apache/arrow-rs/blob/7ec3f5ab0c41f10ece65d3745b989ddde510539b/parquet-variant/src/variant/metadata.rs#L378-L397
##########
parquet-variant/src/main/java/org/apache/parquet/variant/Variant.java:
##########
@@ -282,7 +284,7 @@ public Variant getFieldByKey(String key) {
int mid = (low + high) >>> 1;
int midId = VariantUtil.readUnsignedLittleEndian(value, idStart +
info.idSize * mid, info.idSize);
String midKey = getMetadataKeyCached(midId);
- int cmp = midKey.compareTo(key);
+ int cmp = VariantUtil.compareKeys(VariantUtil.encodeKey(midKey),
keyBytes);
Review Comment:
Should we preserve read compatibility with Variant values written by earlier
parquet-java versions? Its writers sorted object entries using Java
`String.compareTo`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
