asifsmohammed commented on PR #3700: URL: https://github.com/apache/parquet-java/pull/3700#issuecomment-5459654366
@wgtmac thanks for the feedback. Please take a look again and let me know if you have further concerns or questions. > The basic idea is to make `ParsedVersion` retain the parse failure, so callers can reuse the original exception instead of parsing the same version again just to reconstruct the warning. Thats a great suggestion, added `getSemanticVersionParseFailure` > In `ParquetMetadataConverter`, both the legacy String path and the cached ParsedVersion path now share one statistics-conversion implementation. The corrupt-statistics check is selected lazily only for legacy min/max statistics, which removes the duplicated conversion logic and the `useWriterVersion` branch while keeping the existing String entry point intact. Removed duplicate implementation in `fromParquetStatisticsInternal`, `buildColumnChunkMetaData` and also removed `useWriterVersion` flag. Now we just call `shouldIgnoreStatistics` based on parsed version value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
