rdblue commented on PR #3709: URL: https://github.com/apache/parquet-java/pull/3709#issuecomment-5496748630
Using snapshot builds is an interesting idea, but I think it's simpler to just vendor the file. I like having the file here so that we can see when it was updated, what version it came from, and whether there have been local changes. With a copy from a snapshot build, I think we'd end up not really knowing exactly what is being used (at least not easily). It would also be harder to test out changes before committing them. I was also surprised by the size of this PR, though. I think that the reason is we are adding requirements that we didn't in the other implementations, like an easy way to check the version or update it automatically. I think it's nice to have those, but the main goal is just to vendor the file and point to the local one. I wouldn't want to split this PR, but if the scope of the util scripts is too much we could to focus on not being tied to a parquet-format release and, separately, the management scripts in a follow up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
