Fokko commented on code in PR #3678:
URL: https://github.com/apache/parquet-java/pull/3678#discussion_r3934499051
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/HadoopInputFile.java:
##########
@@ -109,20 +149,24 @@ public long getLength() {
public SeekableInputStream newStream() throws IOException {
FSDataInputStream stream;
try {
- // this method is async so that implementations may do async HEAD head
+ // this method is async so that implementations may do async HEAD
// requests, such as S3A/ABFS when a file status is passed down.
- final CompletableFuture<FSDataInputStream> future =
fs.openFile(stat.getPath())
- .withFileStatus(stat)
- .opt(OPENFILE_READ_POLICY_KEY, PARQUET_READ_POLICY)
- .build();
+ FutureDataInputStreamBuilder builder =
fs.openFile(path).opt(OPENFILE_READ_POLICY_KEY, PARQUET_READ_POLICY);
Review Comment:
The
[`FutureDataInputStreamBuilder`](https://hadoop.apache.org/docs/stable/api/org/apache/hadoop/fs/FutureDataInputStreamBuilder.html)
is marked as unstable. I think we might want to pick @steveloughran brain here
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
