RussellSpitzer commented on code in PR #3397:
URL: https://github.com/apache/parquet-java/pull/3397#discussion_r3959428444
##########
parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java:
##########
@@ -51,6 +53,8 @@ public class ParquetProperties {
public static final int DEFAULT_DICTIONARY_PAGE_SIZE = DEFAULT_PAGE_SIZE;
public static final boolean DEFAULT_IS_DICTIONARY_ENABLED = true;
public static final boolean DEFAULT_IS_BYTE_STREAM_SPLIT_ENABLED = false;
+ public static final boolean DEFAULT_IS_ALP_ENABLED = false;
+ public static final int DEFAULT_ALP_VECTOR_SIZE =
AlpConfig.DEFAULT_VECTOR_SIZE;
Review Comment:
Why rename this constant? Feels like we should just be calling
AlpConfig.DEFAULT_VECTOR_SIZE at the call site
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
