RussellSpitzer commented on code in PR #3711:
URL: https://github.com/apache/parquet-java/pull/3711#discussion_r3961645217
##########
parquet-column/src/main/java/org/apache/parquet/schema/Types.java:
##########
@@ -344,6 +353,9 @@ public abstract static class BasePrimitiveBuilder<P, THIS
extends BasePrimitiveB
private int precision = NOT_SET;
private int scale = NOT_SET;
private ColumnOrder columnOrder;
+ // When true and an unsupported logical/physical type combination is
encountered, the
+ // annotation is dropped and the column order is forced to "undefined" so
stats are ignored.
Review Comment:
This is a load bearing comment :) I would probably skip all this since it's
a implementation detail that can go stale pretty quickly. Instead stick to the
behavior.
For example you could say "ignoreUnsupportedLogicalAnnotations" as the
variable name and I think that would cover it? Or
"dropUnsupportedLogicalAnnotations"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
