ggershinsky commented on code in PR #3785:
URL: https://github.com/apache/parquet-java/pull/3785#discussion_r4005479847
##########
parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/KeyToolkit.java:
##########
@@ -143,6 +160,80 @@ private TwoLevelCacheWithExpiration<byte[]> getCache() {
}
}
+ static final class KmsClientCacheContext {
+ private final KmsClientFactory factory;
+ private final TwoLevelCacheWithExpiration<KmsClient> kmsClientCache;
+ private final TwoLevelCacheWithExpiration<KeyEncryptionKey>
defaultKekWriteCache;
+ private final TwoLevelCacheWithExpiration<ConcurrentMap<String,
KeyEncryptionKey>> factoryKekWriteCache;
Review Comment:
just curious why the write-side KEKs are separated by KMS client instance id?
(e.g., the same is not done for read-side KEKs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
