efegokdemir opened a new pull request, #3815:
URL: https://github.com/apache/parquet-java/pull/3815

   ### Rationale for this change
   
   The two benchmark uber-JARs currently copy every dependency's 
`META-INF/LICENSE*` and `META-INF/NOTICE*` resource into the shaded artifact. 
This produces multiple license and notice files and makes the local benchmark 
artifacts fail the repository's expected packaging check.
   
   ### What changes are included in this PR?
   
   - Filter dependency license and notice resources during shading.
   - Aggregate them through Maven Shade's Apache license and notice 
transformers.
   - Apply the same configuration to both benchmark uber-JAR modules.
   
   Fixes #3695
   
   ### Are these changes tested?
   
   - PASS: Python XML parsing of both modified POMs.
   - PASS: `git diff --check`.
   - NOT RUN: Maven package/JAR-content validation. The available macOS Java 
runtime is an x86_64 Java 8 Applet Plugin, while this project requires Java 
17+, so Maven cannot start on this Apple Silicon host.
   
   ### Are there any user-facing changes?
   
   No runtime code changes. The generated benchmark JARs now contain 
consolidated `META-INF/LICENSE` and `META-INF/NOTICE` resources.
   
   AI assistance was used for repository navigation and drafting this focused 
change. I reviewed the complete diff and take responsibility for the submitted 
patch.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to