steveloughran commented on code in PR #3562:
URL: https://github.com/apache/parquet-java/pull/3562#discussion_r4111936876
##########
parquet-variant/src/main/java/org/apache/parquet/variant/Variant.java:
##########
@@ -81,43 +104,59 @@ public Variant(byte[] value, int valuePos, int
valueLength, byte[] metadata, int
this(value, metadata.getEncodedBuffer());
}
+ /**
+ * Create a Variant from a tuple of (value, metadata) buffers.
+ * Includes validation of the version and the toplevel structure.
+ * @param value value buffer
+ * @param metadata metadata buffer
+ * @throws UnsupportedOperationException if there is a version mismatch
+ * @throws IllegalArgumentException for any validation failure.
+ */
public Variant(ByteBuffer value, ByteBuffer metadata) {
this.value = value.asReadOnlyBuffer().order(ByteOrder.LITTLE_ENDIAN);
this.metadata = metadata.asReadOnlyBuffer().order(ByteOrder.LITTLE_ENDIAN);
-
- // There is currently only one allowed version.
- if ((metadata.get(metadata.position()) & VariantUtil.VERSION_MASK) !=
VariantUtil.VERSION) {
- throw new UnsupportedOperationException(String.format(
- "Unsupported variant metadata version: %d",
- metadata.get(metadata.position()) & VariantUtil.VERSION_MASK));
- }
+ this.depth = 0;
+ // A metadata buffer must contain at least the version byte
+ Preconditions.checkArgument(this.metadata.remaining() >= 1, "variant
metadata is empty");
+ // There is no checking of version until a policy of how to handle
mismatched versions
Review Comment:
will fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
