divjotarora commented on code in PR #3827:
URL: https://github.com/apache/parquet-java/pull/3827#discussion_r4246310863
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/ParquetRewriter.java:
##########
Review Comment:
Seems this change is missing test coverage?
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java:
##########
@@ -1078,6 +1078,16 @@ public void writeDataPage(
* @param bloomFilter the bloom filter of column values
*/
public void addBloomFilter(String column, BloomFilter bloomFilter) {
+ addBloomFilterForPath(ColumnPath.fromDotString(column), bloomFilter);
Review Comment:
+1 seems safest to deprecate methods that rely on strings for column paths
as it's an ambiguous API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
