brkyvz commented on code in PR #3608:
URL: https://github.com/apache/parquet-java/pull/3608#discussion_r4426836436


##########
parquet-column/src/test/java/org/apache/parquet/schema/TestTypeBuildersWithLogicalTypes.java:
##########


Review Comment:
   Added coverage in 
[TestFileValueWriter](https://github.com/apache/parquet-java/blob/bab237a1f7b57457052f520f7cd5dae84b211e16/parquet-column/src/test/java/org/apache/parquet/file/Test
           FileValueWriter.java#L129) for offset without size, offset/size 
without a URI, and negative offset/size. 
[TestFileValueReadWrite](https://github.com/apache/parquet-java/blob/bab237a1
           
f7b57457052f520f7cd5dae84b211e16/parquet-hadoop/src/test/java/org/apache/parquet/file/TestFileValueReadWrite.java#L76)
 round-trips valid values, including a zero offset and zero size
           , and checks that invalid stored references convert to null. The 
shared checks live in 
[FileValueValidator.validateValue](https://github.com/apache/parquet-java/blob/bab237a1f7b57457
           
052f520f7cd5dae84b211e16/parquet-column/src/main/java/org/apache/parquet/file/FileValueValidator.java#L35),
 called before writing and after assembling a value on read.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to