rok commented on code in PR #624:
URL: https://github.com/apache/parquet-format/pull/624#discussion_r4423442894
##########
src/main/thrift/parquet.thrift:
##########
@@ -1366,7 +1390,10 @@ struct ColumnIndex {
* A list containing the number of NaN values for each page. Only present
* for columns of physical type FLOAT or DOUBLE, or logical type FLOAT16.
* If this field is not present, readers MUST assume that there might be
- * NaN values in any page.
+ * NaN values in any page, except if the column is an element leaf of a
+ * VECTOR, whose elements MUST by convention always be finite (see
+ * LogicalTypes.md), writers SHOULD omit nan_counts field and
+ * readers MAY assume nan_counts == 0.
Review Comment:
Agreed! How about just removing it as we did here
https://github.com/apache/parquet-format/pull/624#discussion_r4097138105 ?
(Pushed removal, please see if it's ok)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]