RussellSpitzer commented on code in PR #3935:
URL: https://github.com/apache/parquet-java/pull/3935#discussion_r4496473230
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java:
##########
@@ -1269,10 +1286,12 @@ public void writeDataPageV2(
* @param compressed whether the data bytes is compressed
* @param uncompressedDataSize the size of uncompressed data
* @param statistics the statistics of the page
- * @param metadataBlockEncryptor encryptor for block data
+ * @param metadataBlockEncryptor encryptor for the page header
* @param pageHeaderAAD pageHeader AAD
* @throws IOException if any I/O error occurs during writing the file
+ * @deprecated will be removed in 2.0.0. Use {@link #writeDataPageV2(int,
int, int, BytesInput, BytesInput, Encoding, BytesInput, boolean, int,
Statistics, BlockCipher.Encryptor, byte[], SizeStatistics,
BlockCipher.Encryptor, byte[])} instead
Review Comment:
Wrapped in f1a75bc98, along with the same line on the other three deprecated
overloads. Spotless (palantir) doesn't rewrap Javadoc, and the file has both
styles, but these were the only lines over 120 characters in the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]