RussellSpitzer commented on code in PR #3935:
URL: https://github.com/apache/parquet-java/pull/3935#discussion_r4590304207


##########
parquet-hadoop/README.md:
##########
@@ -451,6 +451,10 @@ Note: nested column names must be specified as full 
dot-separated paths for each
 
 **Property:** `parquet.encryption.algorithm`  
 **Description:** Parquet encryption algorithm. Can be `AES_GCM_V1` or 
`AES_GCM_CTR_V1`.  
+Since 1.19.0, DataPageV2 pages of encrypted columns encrypt the repetition and 
definition levels with the values,
+as the specification requires. Earlier versions wrote the levels in plaintext. 
Version 1.19.0 reads both layouts.
+Versions 1.18 and earlier cannot read the new pages. With `AES_GCM_V1`, 
decryption fails. With `AES_GCM_CTR_V1`,
+the levels are incorrect.  

Review Comment:
   I have no problem changing the note, but I think we probably should just 
break in this edition. Parquet-java will be reading those files incorrectly as 
long as the other implementations exist. Someone who doesn't want the change 
could always not upgrade to 1.19. Personally I like to avoid options that are 
essentially "keep insecure behavior." Do you think there is some other set of 
features a user may want without this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to