[
https://issues.apache.org/jira/browse/PHOENIX-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611290#comment-16611290
]
ASF GitHub Bot commented on PHOENIX-3955:
-----------------------------------------
GitHub user ChinmaySKulkarni opened a pull request:
https://github.com/apache/phoenix/pull/346
PHOENIX-3955: Ensure KEEP_DELETED_CELLS, REPLICATION_SCOPE, and TTL
properties stay in sync between the physical data table and index tables
Changes in this commit:
- Disallow specifying any of these properties per-CF when creating any table
- Disallow specifying any of these properties when creating an index
- When creating an index, make sure the above properties are got from the
base table
- Disallow specifying CF with these properties when altering a base table
- If any of these properties is altered on a base table, alter this
property for all column indexes for that table, as well as all indexes and the
view index table for that base table
- If adding a new CF, ensure that it gets these property values (like we
used to do for TTL)
- Disallow altering any of these properties for an index
- Add upgrade utility to sync these properties for each base table and its
indexes and view index table
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChinmaySKulkarni/phoenix PHOENIX-3955
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/346.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #346
----
commit 3f5bbca6c83ad65d7d57a72a67648147f7cce9e1
Author: Chinmay Kulkarni <chinmayskulkarni@...>
Date: 2018-09-11T21:30:01Z
PHOENIX-3955: Ensure KEEP_DELETED_CELLS, REPLICATION_SCOPE, and TTL
properties stay in sync between the physical data table and index tables
----
> Ensure KEEP_DELETED_CELLS, REPLICATION_SCOPE, and TTL properties stay in sync
> between the physical data table and index tables
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-3955
> URL: https://issues.apache.org/jira/browse/PHOENIX-3955
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Assignee: Chinmay Kulkarni
> Priority: Major
>
> We need to make sure that indexes inherit the REPLICATION_SCOPE,
> KEEP_DELETED_CELLS and TTL properties from the base table. Otherwise we can
> run into situations where the data was removed (or not removed) from the data
> table but was removed (or not removed) from the index. Or vice-versa. We also
> need to make sure that any ALTER TABLE SET TTL or ALTER TABLE SET
> KEEP_DELETED_CELLS statements propagate the properties to the indexes too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
