Github user karanmehta93 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/309#discussion_r219293615
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixMapReduceUtil.java
 ---
    @@ -157,6 +192,216 @@ public static void setOutput(final Job job, final 
String tableName,final String
             
PhoenixConfigurationUtil.setUpsertColumnNames(configuration,columns.split(","));
         }
     
    +    /**
    +     * Generate a query plan for a MapReduce job query.
    +     * @param configuration The MapReduce job configuration
    +     * @return Query plan for the MapReduce job
    +     * @throws SQLException If the plan cannot be generated
    +     */
    +    public static QueryPlan getQueryPlan(final Configuration configuration)
    +            throws SQLException {
    +        return getQueryPlan(configuration, false);
    +    }
    +
    +    /**
    +     * Generate a query plan for a MapReduce job query
    +     * @param configuration The MapReduce job configuration
    +     * @param isTargetConnection Whether the query plan is for the target 
HBase cluster
    +     * @return Query plan for the MapReduce job
    +     * @throws SQLException If the plan cannot be generated
    +     */
    +    public static QueryPlan getQueryPlan(final Configuration configuration,
    +            boolean isTargetConnection) throws SQLException {
    +        Preconditions.checkNotNull(configuration);
    +        try {
    +            final String txnScnValue = 
configuration.get(PhoenixConfigurationUtil.TX_SCN_VALUE);
    +            final String currentScnValue = 
configuration.get(PhoenixConfigurationUtil.CURRENT_SCN_VALUE);
    +            final String tenantId = 
configuration.get(PhoenixConfigurationUtil.MAPREDUCE_TENANT_ID);
    +            final Properties overridingProps = new Properties();
    +            if(txnScnValue==null && currentScnValue!=null) {
    --- End diff --
    
    nit: spaces (applicable everywhere in general)


---

Reply via email to