[
https://issues.apache.org/jira/browse/PHOENIX-5079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735957#comment-16735957
]
Hadoop QA commented on PHOENIX-5079:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12953998/PHOENIX-5079-4.x-HBase-1.3.001.patch
against 4.x-HBase-1.3 branch at commit
52a89f05f5e8a131fdf3ac990d7cfe29cc204711.
ATTACHMENT ID: 12953998
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexReplicationIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2234//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2234//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2234//console
This message is automatically generated.
> PhoenixIndexMetaData.isIndexRebuild gives wrong results in Partial Index
> Rebuilding
> -----------------------------------------------------------------------------------
>
> Key: PHOENIX-5079
> URL: https://issues.apache.org/jira/browse/PHOENIX-5079
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.14.1
> Reporter: Monani Mihir
> Assignee: Monani Mihir
> Priority: Minor
> Attachments: PHOENIX-5079-4.x-HBase-1.3.001.patch
>
>
> During Partial Rebuild, If rebuilder get index failure (because of region
> move/split etc), it will call PhoenixIndexFailurePolicy.handleFailure . Here
> it checks if mutations are part of Index Rebuild or not .
> {code:java}
> if (!throwing) {
> SQLException sqlException =
> new
> SQLExceptionInfo.Builder(SQLExceptionCode.INDEX_WRITE_FAILURE)
>
> .setRootCause(cause).setMessage(cause.getLocalizedMessage()).build()
> .buildException();
> IOException ioException =
> ServerUtil.wrapInDoNotRetryIOException(null, sqlException, timestamp);
> Mutation m = attempted.entries().iterator().next().getValue();
> boolean isIndexRebuild =
> PhoenixIndexMetaData.isIndexRebuild(m.getAttributesMap());
> // Always throw if rebuilding index since the rebuilder needs to
> know if it was successful
> if (throwIndexWriteFailure || isIndexRebuild) {
> throw ioException;
> } else {
> LOG.warn("Swallowing index write failure", ioException);
> }
> }
> {code}
> Here isIndexRebuild becomes false even though we have set attribute for
> REPLY_WRITE to
> REPLAY_ONLY_INDEX_WRITES in UngroupedAggregateRegionObserver.rebuildIndices
> {code:java}
> ...
> put.setAttribute(REPLAY_WRITES, REPLAY_ONLY_INDEX_WRITES);
> ...{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
