[
https://issues.apache.org/jira/browse/PHOENIX-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812630#comment-16812630
]
Hadoop QA commented on PHOENIX-4476:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12934436/PHOENIX-4476-4.x-HBase-1.3.003.patch
against 4.x-HBase-1.3 branch at commit
43600fbf39cda4336be9736fd8c653044e3d85ee.
ATTACHMENT ID: 12934436
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 4 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ for (int i = 0; i <
whereClause.getChildren().get(0).getChildren().size(); i++) {
+ if
(whereClause.getChildren().get(0).getChildren().get(i).toString().equals(pColumn.toString()))
{
+ boolean needReorder = pkSet.size() ==
context.getCurrentTable().getTable().getPKColumns().size();
+ Expression newKey = new
RowValueConstructorExpression(newKeyChildren, key.isStateless());
+ sortedKeys.add(
whereClause.getChildren().get(0).getChildren().subList(pkOrder.get(i),pkOrder.get(i)+1).get(0));
+ childrenForSortedWhereClause.add(new
RowValueConstructorExpression(sortedKeys, false));
+ sortedWhereClause = InListExpression.create(
childrenForSortedWhereClause, false,
+ return new SingleKeySlot(new
RowValueConstructorKeyPart(table.getPKColumns().get(initialPosition), rvc,
span, childSlots, positionOrder), initialPosition, span, EVERYTHING_RANGES);
+ sortedChildren.add(new
RowValueConstructorExpression(sortedExpression,
node.getChildren().get(0).isStateless()));
+
sortedExpressionList.add(node.getKeyExpressions().get(i).getChildren().get(correctIndex));
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.phoenix.compile.QueryCompilerTest
org.apache.phoenix.compile.QueryOptimizerTest
org.apache.phoenix.expression.NullValueTest
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2495//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2495//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2495//console
This message is automatically generated.
> Range scan used for point lookups if filter is not in order of primary keys
> ---------------------------------------------------------------------------
>
> Key: PHOENIX-4476
> URL: https://issues.apache.org/jira/browse/PHOENIX-4476
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.13.1
> Reporter: Mujtaba Chohan
> Assignee: Xu Cang
> Priority: Major
> Labels: SFDC
> Attachments: PHOENIX-4476-4.x-HBase-1.3.002.patch,
> PHOENIX-4476-4.x-HBase-1.3.003.patch
>
>
> {noformat}
> DROP TABLE TEST;
> CREATE TABLE IF NOT EXISTS TEST (
> PK1 CHAR(1) NOT NULL,
> PK2 VARCHAR NOT NULL,
> PK3 VARCHAR NOT NULL,
> PK4 UNSIGNED_LONG NOT NULL,
> PK5 VARCHAR NOT NULL,
> V1 VARCHAR,
> V2 VARCHAR,
> V3 UNSIGNED_LONG
> CONSTRAINT state_pk PRIMARY KEY (
> PK1,
> PK2,
> PK3,
> PK4,
> PK5
> )
> );
> // Incorrect explain plan with un-ordered PKs
> EXPLAIN SELECT V1 FROM TEST WHERE (PK1, PK5, PK2, PK3, PK4) IN (('A', 'E',
> 'N', 'T', 3), ('A', 'Y', 'G', 'T', 4));
> +------------------------------------------+------------------------------------------+------------------------------------------+---------+
> | PLAN | EST_BYTES_READ
> | EST_ROWS_READ | |
> +------------------------------------------+------------------------------------------+------------------------------------------+---------+
> | CLIENT 1-CHUNK PARALLEL 1-WAY ROUND ROBIN RANGE SCAN OVER TEST ['A'] | null
> | null |
> | SERVER FILTER BY (PK1, PK5, PK2, PK3, PK4) IN
> ([65,69,0,78,0,84,0,0,0,0,0,0,0,0,3],[65,89,0,71,0,84,0,0,0,0,0,0,0,0,4]) |
> null |
> +------------------------------------------+------------------------------------------+------------------------------------------+---------+
> // Correct explain plan with PKs in order
> EXPLAIN SELECT V1 FROM TEST WHERE (PK1,PK2,PK3,PK4,PK5) IN (('A', 'E', 'N',3,
> 'T'),('A', 'Y', 'G', 4, 'T'));
> +------------------------------------------+------------------------------------------+------------------------------------------+---------+
> | PLAN | EST_BYTES_READ
> | EST_ROWS_READ | |
> +------------------------------------------+------------------------------------------+------------------------------------------+---------+
> | CLIENT 1-CHUNK 2 ROWS 712 BYTES PARALLEL 1-WAY ROUND ROBIN POINT LOOKUP ON
> 2 KEYS OVER TEST | 712 | |
> +------------------------------------------+------------------------------------------+------------------------------------------+---------+
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
