[
https://issues.apache.org/jira/browse/PHOENIX-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817233#comment-16817233
]
Lars Hofhansl commented on PHOENIX-5233:
----------------------------------------
It's only called when one the source tables equals the target table. (i.e. only
in UPSERT/SELECT). I think we can safely turn always snapshot - as it seems we
must.
Whether 50 is enough. Who knows? :) We could increase it to 100, but I think
it's rare that someone would do so many UPSERT/SELECTs in a single transaction.
OK... So here's a plan:
# You commit OMID-144 (I see you did already)
# Then do you want to do a formal Omid 1.0.1 release?
# (Assuming +1's) I'll commit PHOENIX-5225 (default to Omid 1.0.1 in Phoenix)
# Here I'll post a new patch containing the two tests and the fix shown in my
comment. Then I commit this here (assuming I'll get a +1)
# I'll review or post a new patch on PHOENIX-5090. And commit that one too.
And then we'll have a good story!
> Read-your-own writes causes incorrect visibility with transactional tables
> (with Omid).
> ---------------------------------------------------------------------------------------
>
> Key: PHOENIX-5233
> URL: https://issues.apache.org/jira/browse/PHOENIX-5233
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.14.1
> Reporter: Lars Hofhansl
> Assignee: Yonatan Gottesman
> Priority: Major
> Attachments: 5233-tests.txt, 5233-v4.txt, 5233-v5.txt, 5233-v6.txt
>
>
> (copied from my last comment on PHOENIX-5090)
> Steps to reproduce (with Omid):
> # {{!autocommit off}}
> # {{create table test (pk1 integer not null, pk2 integer not null, pk3
> integer not null, v1 float, v2 float, v3 integer CONSTRAINT pk PRIMARY KEY
> (pk1, pk2, pk3)) DISABLE_WAL=true, TRANSACTIONAL=true;}}
> # {{upsert into test values(rand()*10000000, rand()*10000000,
> rand()*10000000, rand(), rand(), rand()*1000000);}}
> # {{upsert into test select rand()*10000000, rand()*10000000,
> rand()*10000000, rand(), rand(), rand()*1000000 from test;}}
> # {{select count\(*) from test; – this will cause uncommitted data to sent
> to the server.}}
> # Goto #4 a few time (until you inserted 131072 rows)
> # {{!commit}}
> In a separate sqlline session just repeat after the commit was issued in the
> other session.
> * {{select count\(*) from test;}}
> You'll see that number will change until it finally settles.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
