[ 
https://issues.apache.org/jira/browse/PHOENIX-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963030#comment-16963030
 ] 

Josh Elser commented on PHOENIX-5554:
-------------------------------------

Nice! That's a fun little fact I never realized.

Referenced docs at 
[https://maven.apache.org/surefire/maven-failsafe-plugin/examples/fork-options-and-parallel-execution.html]

+1 on this change. One of those super-straightforward but time-consuming ones. 
Thanks for working through the change.

> Synchronize @Parameters, @BeforeClass and @AfterClass methods
> -------------------------------------------------------------
>
>                 Key: PHOENIX-5554
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5554
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: István Tóth
>            Assignee: István Tóth
>            Priority: Major
>         Attachments: PHOENIX-5554.master.v1.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> According to the failsafe docs, all methods that are annotated with 
> @Parameters, @BeforeClass and @AfterClass should be synchronized.
> This is not just a theoretical problem, it causes random test failures, like 
> [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3078//testReport/org.apache.phoenix.end2end/DescOrderKeysIT/org_apache_phoenix_end2end_DescOrderKeysIT/]
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to