joshelser commented on a change in pull request #7: PHOENIX-5552 Hive against
Phoenix gets 'Expecting "RPAREN", got "L"' …
URL: https://github.com/apache/phoenix-connectors/pull/7#discussion_r342138715
##########
File path:
phoenix-hive/src/main/java/org/apache/phoenix/hive/constants/PhoenixStorageHandlerConstants.java
##########
@@ -91,6 +92,7 @@
public static final String DATE_PATTERN = "'?\\d{4}-\\d{2}-\\d{2}'?";
public static final String TIMESTAMP_PATTERN = "'?\\d{4}-\\d{2}-\\d{2}
\\d{2}:\\d{2}:\\d{2}\\" +
".?\\d{0,9}'?";
+ public static final String BIGINT_PATTERN = "[0-9]+L";
Review comment:
Is the `L` only allowed to be capitalized? Or would `10l` (lowercase 'L')
also be valid from the Hive side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
