[
https://issues.apache.org/jira/browse/PHOENIX-5564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971018#comment-16971018
]
Hadoop QA commented on PHOENIX-5564:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12985443/PHOENIX-5564.master.001.patch
against master branch at commit 70baf4c6805eb46420dd1fbaf71a093ab7d84a8b.
ATTACHMENT ID: 12985443
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ // GlobalIndexChecker passed the index row
key. This is to build a single index row.
+ // Check if the data table row we have just
scanned matches with the index row key.
+ // If not, there is no need to build the index
row from this data table row,
+ * If an index row is unverified (i.e., the row status is unverified), the
following steps are taken :
+ * (1) We generate the data row key from the index row key, and check if the
data row exists. If not, this unverified
+ * index row is skipped (i.e., not returned to the client), and it is deleted
if it is old enough. The age check is
+ * necessary in order not to delete the index rows that are currently being
updated. If the data row exists,
+ * (3) The current scanner is closed as the newly rebuilt row will not be
visible to the current scanner.
+ * (4) if the data row does not point back to the unverified index row (i.e.,
the index row key generated from the data
+ * row does not match with the row key of the unverified index row), this
unverified row is skipped and and it is
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3109//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3109//console
This message is automatically generated.
> Restructure read repair to improve readability and correctness
> --------------------------------------------------------------
>
> Key: PHOENIX-5564
> URL: https://issues.apache.org/jira/browse/PHOENIX-5564
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.1.0
> Reporter: Kadir OZDEMIR
> Assignee: Kadir OZDEMIR
> Priority: Major
> Attachments: PHOENIX-5564.master.001.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The logic in read repair has gotten complicated and needs to be restructured
> for better readability and ensuring its correctness. More exceptions are
> needed to catch unexpected conditions and/or make sure that they do not
> happen.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
