[ https://issues.apache.org/jira/browse/PHOENIX-5697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023190#comment-17023190 ]
Viraj Jasani commented on PHOENIX-5697: --------------------------------------- [~gjacoby] [~larsh] Could you please review the patch? > Avoid resource leakage with try-with-resources > ---------------------------------------------- > > Key: PHOENIX-5697 > URL: https://issues.apache.org/jira/browse/PHOENIX-5697 > Project: Phoenix > Issue Type: Improvement > Affects Versions: 5.1.0, 4.15.1 > Reporter: Viraj Jasani > Assignee: Viraj Jasani > Priority: Major > Labels: phoenix-hardening > Attachments: PHOENIX-5697.master.000.patch > > > There are places where we catch IOException in finally block while closing a > closable resource. If we could use try-with-resources to deal with closure of > resources, that would not let us worry about catching IOException while > closing the resources and would be a better replacement. -- This message was sent by Atlassian Jira (v8.3.4#803005)