[
https://issues.apache.org/jira/browse/PHOENIX-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066842#comment-17066842
]
Istvan Toth commented on PHOENIX-5780:
--------------------------------------
The attached patch is quite large and noisy, so I will try to summarize the
changes.
The main goal was to make dependency:analyze pass, i.e. have the poms reflect
the actually used dependencies.
The secondary goal was to have all dependency versions consolidated to
properties/dependencyManagement.
Upgrading dependency versions was a non-goal, for this ticket.
I have also made some minor changes the java code that should not affect the
the functionality adversely, but let me remove dependencies:
* replaced commons-lang with commons-lang3
* replaced commons-logging with slf4j (this looks like an oversight/bug)
* replaced com.sun.istack.NotNull with edu.umd.cs.findbugs.annotations.NonNull
(this actually may do something with findbugs)
* replaced io.netty.util.internal.ThreadLocalRandom with
java.util.concurrent.ThreadLocalRandom
* removed spurious jline.internal.TestAccessible import
* fixed a test in pherf that failed on Mac
The resulting dependencies are by design very close to the dependencies without
the patch, as this is meant to be a foundation on which further
build/dependency work can be built.
Most of these changes would apply to 4.x, but it would have to be re-done,
instead of cherry-picking, so the patch is for master only for now.
> Add mvn dependency:analyze to build process
> -------------------------------------------
>
> Key: PHOENIX-5780
> URL: https://issues.apache.org/jira/browse/PHOENIX-5780
> Project: Phoenix
> Issue Type: Task
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
> Attachments: PHOENIX-5780.master.v1.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> mvn dependency:analyze has shown that the dependency definitions in Phoenix
> are in a bad shape.
> Include it in the build process, so that we can keep the dependencies true
> and up to date.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
