jpisaac commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp URL: https://github.com/apache/phoenix/pull/724#discussion_r402493827
########## File path: phoenix-core/src/main/java/org/apache/phoenix/parse/PhoenixRowTimestampParseNode.java ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.phoenix.parse; + +import org.apache.phoenix.compile.StatementContext; +import org.apache.phoenix.expression.Expression; +import org.apache.phoenix.expression.KeyValueColumnExpression; +import org.apache.phoenix.expression.function.FunctionExpression; +import org.apache.phoenix.expression.function.PhoenixRowTimestampFunction; +import org.apache.phoenix.query.QueryConstants; +import org.apache.phoenix.schema.PDatum; +import org.apache.phoenix.schema.PTable; +import org.apache.phoenix.schema.SortOrder; +import org.apache.phoenix.schema.types.PDataType; +import org.apache.phoenix.schema.types.PDate; +import org.apache.phoenix.util.IndexUtil; +import org.apache.phoenix.util.SchemaUtil; + +import java.sql.SQLException; +import java.util.Arrays; +import java.util.List; + +public class PhoenixRowTimestampParseNode extends FunctionParseNode { + + PhoenixRowTimestampParseNode(String name, List<ParseNode> children, + BuiltInFunctionInfo info) { + super(name, children, info); + } + + @Override + public FunctionExpression create(List<Expression> children, StatementContext context) throws SQLException { + + // PhoenixRowTimestampFunction does not take any parameters. + assert children.size() == 0; Review comment: Found that when a param is passed into PHOENIX_ROW_TIMESTAMP it gets parsed as UDFParseNode. But added the check and exception anyways. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
