[
https://issues.apache.org/jira/browse/PHOENIX-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17081097#comment-17081097
]
Hadoop QA commented on PHOENIX-4521:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12999591/PHOENIX-4521.master.v5.patch
against master branch at commit 39a34b8fae743c63f634ef0366c2de130a621bbe.
ATTACHMENT ID: 12999591
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 2 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ +
",START_TIME,QUERY_GROUP,QUERY_ID,QUERY,TENANT_ID,THREAD_NUMBER,CONCURRENCY_LEVEL"),
+ LOGGER.info("Queryset timeout of " + executionDurationInMs + "
ms reached; current time is " + elapsedTime + " ms."
+ + "\nStopping queryset execution for query " +
query.getId() + " on thread " + threadName + "...");
+ * @return a Pair whose first value is the resultRowCount, and whose
second value is whether the query timed out.
+ Pair<Long, Boolean> getResults(ResultSet rs, String queryIteration,
boolean isSelectCountStatement) throws Exception {
+ <!-- This column type defines what will generally happen to
VARCHAR fields unless they are explicitly defined or overridden elsewhere -->
+ <!--Note: 1. Minimum of executionDurationInMs or
numberOfExecutions. Which ever is reached first
+ 2. DDL included in query are executed only once on start
of querySet execution.
+ <querySet concurrency="1-3" executionType="SERIAL"
executionDurationInMs="5000" numberOfExecutions="10">
+ The value will be dumped to results. This gives a value to
group by on reporting to compare queries -->
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinLocalIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DropTableWithViewsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.SubqueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpsertSelectIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3743//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3743//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3743//console
This message is automatically generated.
> Allow Pherf scenario to define per query max allowed query execution duration
> after which thread is interrupted
> ---------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-4521
> URL: https://issues.apache.org/jira/browse/PHOENIX-4521
> Project: Phoenix
> Issue Type: Improvement
> Reporter: James R. Taylor
> Assignee: Christine Feng
> Priority: Major
> Labels: phoenix-hardening
> Attachments: PHOENIX-4521.master.v1.patch,
> PHOENIX-4521.master.v2.patch, PHOENIX-4521.master.v2.patch,
> PHOENIX-4521.master.v3.patch, PHOENIX-4521.master.v4.patch,
> PHOENIX-4521.master.v5.patch
>
> Time Spent: 10h 50m
> Remaining Estimate: 0h
>
> Some clients interrupt the client thread if it doesn't complete in a required
> amount of time. It would be good if Pherf supported setting this up so we
> mimic client behavior more closely, as we're theorizing this may be causing
> some issues.
>
> PLAN
> # Make necessary changes so new timeoutDuration property is recognized and
> parsed correctly from the scenario .xml file (completed)
> # Implement a per-query, per-iteration timeout
> # Write ITs and UTs
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
