joshelser commented on a change in pull request #25:
URL: https://github.com/apache/phoenix-queryserver/pull/25#discussion_r412305333
##########
File path: pom.xml
##########
@@ -120,39 +121,6 @@
<artifactId>maven-eclipse-plugin</artifactId>
<version>${maven-eclipse-plugin.version}</version>
</plugin>
- <plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>build-helper-maven-plugin</artifactId>
- <version>${maven-build-helper-plugin.version}</version>
- <executions>
- <execution>
- <id>add-test-source</id>
- <phase>validate</phase>
- <goals>
- <goal>add-test-source</goal>
- </goals>
- <configuration>
- <sources>
- <source>${basedir}/src/it/java</source>
- </sources>
- </configuration>
- </execution>
- <execution>
- <id>add-test-resource</id>
- <phase>validate</phase>
- <goals>
- <goal>add-test-resource</goal>
- </goals>
- <configuration>
- <resources>
- <resource>
-
<directory>${basedir}/src/it/resources</directory>
- </resource>
- </resources>
- </configuration>
- </execution>
- </executions>
- </plugin>
Review comment:
I missed that we had ITs in those. I thought we only had them for
queryserver (now queryserver-it). Restoring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
